Skip to content

Refactor MigrationGenerator class #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 17, 2020
Merged

Refactor MigrationGenerator class #376

merged 7 commits into from
Sep 17, 2020

Conversation

ghostwriter
Copy link
Contributor

@ghostwriter ghostwriter commented Sep 13, 2020 •
edited
Loading

Currently:

PR

  • fix Problem is with two-word model names #374
  • refactor: migration generator class
    • create migrations sequential with unique timestamp.
    • create modelTables before pivotTables
    • remove dead code
  • update migration generator fixtures, stubs, and tests

@jasonmccreary jasonmccreary merged commit 0942543 into laravel-shift:master Sep 17, 2020
@ghostwriter ghostwriter deleted the bugfix/migration-generator branch September 17, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem is with two-word model names
2 participants
@ghostwriter @jasonmccreary