Skip to content

fix pivot table naming bug #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix pivot table naming bug #387

wants to merge 1 commit into from

Conversation

MuathIbnHassan
Copy link

the bug happens when using path prefix on models name

like this one :

  Lookup\Region:
    name_en: string:255 nullable
    softDeletes
    relationships:
      hasMany: Lookup\City

when there is a belongsToMany relationship, the path will be added to the pivot migration name which is not right

@jasonmccreary
Copy link
Collaborator

While I appreciate this is the fix, I'd like to see a test for this.

@Pr3d4dor Pr3d4dor mentioned this pull request Oct 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuathIbnHassan @jasonmccreary