Skip to content

Add string limit for faker words #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2021
Merged

Add string limit for faker words #437

merged 3 commits into from
Mar 5, 2021

Conversation

ghostwriter
Copy link
Contributor 

models:
  Post:
    tag: string:3
  • string:{limit} syntax will now generate $faker->regexify('[A-Za-z0-9]{limit}') instead of $faker->word.

Resolves #434

@jasonmccreary
Copy link
Collaborator

jasonmccreary commented Mar 5, 2021 •
edited
Loading

Surprised Faker doesn't have characters or randomLetters. Would be much more readable than regexify.

@jasonmccreary jasonmccreary merged commit b7d20a8 into laravel-shift:master Mar 5, 2021
@ghostwriter ghostwriter deleted the support-faker-words-string-limit branch March 5, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model definition using string generates faker words which are too long
2 participants
@ghostwriter @jasonmccreary