-
Notifications
You must be signed in to change notification settings - Fork 288
Refactor filesystem mocks #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor filesystem mocks #449
Conversation
I vaguely remember there being an issue when using It won't be something that appears in the tests since we're mocking, but it will be an issue at runtime. Especially if someone has swapped it out in the container. However, I'm not sure if we'd want to use that anyway. So it's probably fine, but wanted to brain dump before merging to get your thoughts... |
Blueprint uses both Which I understand as, it accepts the concrete class in some places instead of the interface, and the tests partially mocks the interface. To your point, i’ll update this PR to use the concrete implementation (I assume since Blueprint is specifically for Laravel, devs wouldn’t need a 3rd party library for filesystem when one is provided “out of the box”.) |
@nathane, I'm fine either way. To your point, just want it to be consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever recent commit you made had very opinionated formatting and importing rules.
@nathane, best to undo the "scouting" commit. It has all sort of opinionated formatting and the class reference, while I generally agree with, actually make the code harder to test since it's not within the Laravel framework. |
This reverts commit ca99cef.
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
TestCase.php
MocksFilesystem
trait