Bug/remove double white space first relationship method #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s declaration Signed-off-by: Ben James <in@benjam.es>
Signed-off-by: Ben James <in@benjam.es>
benjam-es
changed the title
benjam-es
changed the title
|
@benjam-es thanks for this. However, can you work towards a cleaner implementation. The temporary variable, inline coalesce, and iterative assignment are a bit heavy. |
… the file Signed-off-by: Ben James <in@benjam.es>
|
@jasonmccreary much simpler solution added once realising that white space must be trimmed at the end of classes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on a different pull request, I kept hitting an issue, only to discover my auto code cleanup was removing double spaces from my fixtures, which would then prevent the fixture matching the output.
Separated into two commits. One for the fixture cleanup, and another for the solution, incase you want the solution to be carried out in a different way.
Solves #520