Skip to content

Return correct return-type hints #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 5, 2023
Merged

Return correct return-type hints #591

merged 7 commits into from
Jan 5, 2023

Conversation

ghostwriter
Copy link
Contributor

Resolves #589

@ghostwriter
Add draft file
e849935 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Add test fixtures with expected output
5ac6186 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Add test
5628695 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Return correct return-type hints
653323b 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Update other fixtures
8710573 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@ghostwriter
Appease the CI gods
6992a43 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@jasonmccreary
Copy link
Collaborator

You can run vendor/bin/pint locally to fix everything you need.

@ghostwriter
Fix Pint issues
5835ed5 
Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@jasonmccreary jasonmccreary merged commit 8db6637 into laravel-shift:master Jan 5, 2023
@ghostwriter ghostwriter deleted the bugfix/controller-returns-view-typehint branch January 5, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong return type on controller, when returning a View
2 participants
@ghostwriter @jasonmccreary