-
Notifications
You must be signed in to change notification settings - Fork 288
Add ability to generate API resource controllers #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This code looks good, but again, with no tests, I can't merge such a large feature. |
Also, please remove the |
Okay! No problem, thought it might help other contributors. I’m really not good at writing tests but I’ll try to follow along. |
If it were project specific stuff, sure. This project already uses PHP CS and Style CI. So there's no reason to add Prettier. And As far as the tests, it's okay if you don't have full coverage. Maybe try to add one for the |
# Conflicts: # src/Generators/ControllerGenerator.php # src/Lexers/StatementLexer.php
I'm happy to help write some tests for this, if you would like. I'm digging this tool and your commit could be very helpful to me. |
by all means! |
I'm going to work on this today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read the source of blueprint until now, but your changes look pretty clean, I need to make sure the tests are up to JMac standards and I honestly haven't learned his approach at all before today, but I should be able. Really a good PR for my uses, personally, nice work!
@defenestrator no worries. Take a crack at it and I can always clean it up. Maybe a live-stream Friday. |
I started working on this earlier. Due to GitHub's limitations for working on a contributors branch directly, I am going to close this and will open a new one with your work + mine. |
I didn't know there were GitHub limitations that would cause an issue, interesting. I had other priorities, had to delay this, dang it. I have a handle on your testing stuff, dig those fixtures. I'm checking out that new branch now. |
No worries. If you have changes you did, you can try to PR them into the branch I made. |
Hi!
I've extracted API Resource related changes from my fork into this PR.
Please take a look, does everything makes sense?
Tried to keep unrelated changes to the minimum, had to add prettier config so my editor wouldn't reformat the whole file on every save :)