Add a flag in ObservedBy attribute to skip registration in tests

[chack1172]

I was thinking about this for situations where there can be an observer that runs non important tasks that can make tests fail but we don't want to test that. In case the observer need to be tested it can be manually register with Model::observe().

[shaedrich]

Adding code only for testing is bad style. You can mute events already:

use App\Models\User;

$user = User::withoutEvents(function () {
    User::findOrFail(1)->delete();
 
    return User::find(2);
});

[chack1172]

I know about that but what if the observer is added later in the projects and it will make you fail all the existing tests

[shaedrich]

Tests are not set in stone. You can change them. Or rethink if you really need the observer. That's the way the cookie crumbles.

[chack1172]

Instead of a flag for test environment, what about adding a static shouldAutoregister() method to the observer that is checked when autoregistering observers assigned with ObservedBy attribute?

[shaedrich]

And what should it do if it is set to false? Manually register outside of tests? Doesn't sound feasible 🤔