fix: use qualifyColumn rather than assuming format #53559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMast
reviewed
Nov 18, 2024
| $this->builder->shouldReceive('where')->with('relation.id', '=', 'foreign.value'); | ||
| $this->related = m::mock(Model::class); | ||
| $this->related->shouldReceive('getKeyName')->andReturn('id'); | ||
| $this->related->shouldReceive('getcolumn')->andReturn('id'); |
There was a problem hiding this comment.
Is this supposed to be getColumn?
There was a problem hiding this comment.
doesn't really matter. method names are not case sensitive.
|
This PR broken |
crynobone
added a commit
that referenced
this pull request
Nov 19, 2024
This reverts commit cff895d.
taylorotwell
pushed a commit
that referenced
this pull request
Nov 19, 2024
…53568) * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Revert "fix: use qualifyColumn rather than assuming format (#53559)" This reverts commit cff895d. * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> --------- Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
|
This PR has been reverted due as it triggers error on certain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my setup I have some Laravel models stored in MongoDB and others in MySQL. MorphTo and BelongsTo relations aren't loading where the parent model is in MongoDB and the child is in MySQL, i.e:
Child::first()->myRelationwill returnnullbecauseaddConstraints()is assuming that the key name should be prepended with the table name, which isn't the case for MongoDB.The
getQualifiedOwnerKeyName()method already exists on the BelongsTo class, is there any reason why it's not currently being used when adding constraints?