Skip to content

Conversation

@SanderMuller
Copy link
Contributor

@SanderMuller SanderMuller commented Jan 14, 2025

Reverts #54134

fixed #54184

@taylorotwell I think this is a breaking change on the old route namespacing eg

Route::namespace('Admin')

    ->group(function (): void {

        Route::view('dashboard', 'admin.dashboard');

    });

this now throws Invalid route action: [App\Http\Controllers\Admin\Illuminate\Routing\ViewController]. because the namespace in this PR was changed from \Illuminate\Routing\ViewController to Illuminate\Routing\ViewController I think.

image

SanderMuller added a commit to SanderMuller/framework that referenced this pull request Jan 14, 2025
@SanderMuller
Copy link
Contributor Author

The same test change has been added in #54186 which shows that the added test fails on the 11.x branch but not in this revert PR with regression test

Comment on lines +253 to +254
'\Illuminate\Routing\RedirectController',
'\Illuminate\Routing\ViewController',
Copy link
Contributor

@shaedrich shaedrich Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'\Illuminate\Routing\RedirectController',
'\Illuminate\Routing\ViewController',
'\\' . Illuminate\Routing\RedirectController::class,
'\\' . Illuminate\Routing\ViewController::class,

probably isn't much better, is it?

@taylorotwell taylorotwell merged commit a06a0dc into laravel:11.x Jan 14, 2025
38 checks passed
taylorotwell pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new release v11.38.0 breaks redirect routes

4 participants