Incorrect route matched when part of URL overlaps

[mnastalski]

Laravel Version

12.33.0

PHP Version

8.3

Database Driver & Version

No response

Description

Most likely related to #56920, starting from 12.29.0, some parameters seem to get ignored as long as the first found route partially matches the path. Query string is created for the remaining parameters.

Steps To Reproduce

Assuming the following declaration in routes (and yes, these are from laravel nova, v5.5):

Route::get('/{resource}/attachable/{field}', MyController::class);
Route::get('/{resource}/{resourceId}/attachable/{field}', MyController::class);

Get the URL using action():

action(MyController::class, [
    'resource' => 'posts',
    'resourceId' => 1,
    'field' => 'category',
    'foo' => 'bar',
]);

Pre 12.29.0 the above would match the second route and result in:
(...)/posts/1/attachable/category?foo=bar

While from 12.29.0 it matches the first route and results in:
(...)/posts/attachable/category?resourceId=1&foo=bar"

It's a bit of an edge case but I would expect it to still match the second route

Repository with the above should it be needed:
https://github.com/mnastalski/routing-reproduction/blob/master/routes/web.php
https://github.com/mnastalski/routing-reproduction/blob/master/tests/Feature/ExampleTest.php

[macropay-solutions]

Hi. What happens if you change the order in which you register those routes to:

Route::get('/{resource}/{resourceId}/attachable/{field}', MyController::class);
Route::get('/{resource}/attachable/{field}', MyController::class);

?

If this fixes it then the related #56920 is not the cause. Other thing could generate this.

Update with prior to #56920 version:

Route::get('/{resource}/attachable/{field}', \App\Http\Controllers\MyController::class);
Route::get('/{resource}/{resourceId}/attachable/{field}', \App\Http\Controllers\MyController::class);

prints
"http://example.local/posts/1/attachable/category?foo=bar"

Route::get('/{resource}/{resourceId}/attachable/{field}', \App\Http\Controllers\MyController::class);
Route::get('/{resource}/attachable/{field}', \App\Http\Controllers\MyController::class);

prints
"http://example.local/posts/attachable/category?resourceId=1&foo=bar"

The real issue is that this

    protected function addToActionList($action, $route)
    {
        $this->actionList[trim($action['controller'], '\\')] = $route;
    }

uses the controller and because the controller is the same it registers the first route that uses that controller in the curent version and in the version prior to #56920 it registers the last one.

https://laravel.com/docs/12.x/routing#the-default-route-files

Route::get('/{resource}/attachable/{field}', [\App\Http\Controllers\MyController::class, 'get']);
Route::get('/{resource}/{resourceId}/attachable/{field}', [\App\Http\Controllers\MyController::class, 'getById']);

//and

Route::get('/{resource}/{resourceId}/attachable/{field}', [\App\Http\Controllers\MyController::class, 'getById']);
Route::get('/{resource}/attachable/{field}', [\App\Http\Controllers\MyController::class, 'get']); 


        dd(action([MyController::class, 'getById'], [
            'resource' => 'posts',
            'resourceId' => 1,
            'field' => 'category',
            'foo' => 'bar',
        ]));

result both in:
"http://example.local/posts/1/attachable/category?foo=bar"

Conclusion is that the combination Controller FQN + method should be used only once if you want it to work like this or use unique aliases and retrieve the route by alias using route() helper.

[mnastalski]

Switching the route declarations breaks the other route:

Route::get('/{resource}/{resourceId}/attachable/{field}', MyController::class);
Route::get('/{resource}/attachable/{field}', MyController::class);

$url = action(MyController::class, [
    'resource' => 'posts',
    'field' => 'category',
    'foo' => 'bar',
]);

Illuminate\Routing\Exceptions\UrlGenerationException: Missing required parameter for [Route: ] [URI: {resource}/{resourceId}/attachable/{field}] [Missing parameter: resourceId].

And like I mentioned, these are from Laravel Nova v5.5, therefore I cannot change how they are declared.

[macropay-solutions]

Then you can open an issue there if you can't adapt your code.

PS
The title is wrong. The route string is not involved in action or route helpers.

[mathiasgrimm]

I think it should always return the first route as per previous test that was added to be consistent

I've created a PR that tests this behaviour for actions as well #57347