New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Remove "select" bindings from MySQL delete statments. #22285

merged 2 commits into from Dec 3, 2017


None yet
2 participants

themsaid commented Dec 2, 2017

This PR will ensure "select" bindings are removed and join arguments are put in the correct order:

delete `users` from `users` inner join `names` on `names`.`user_id` = `users`.`id` and `names`.`user_id` = ? where `users`.`id` = ?

Here "join" bindings comes first and then "where" bindings, select bindings aren't needed in the query and thus removed.

themsaid added some commits Dec 2, 2017

@taylorotwell taylorotwell merged commit b2fbec9 into laravel:5.5 Dec 3, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment