[5.7] Services can be injected in migrations #25038
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can type-hint our services in for example the
boot
method of a service provider, therules
andauthorize
methods of aFormRequest
, in thehandle
method of jobs, Artisan commands etc. but the same doesn't apply to the migrationup
anddown
methods. This is not only inconsistent, but it also means that we have no other choice but to use facades or the globalapp()
helper to get our services from the container. There is no reason why we couldn't get our services in the same way we get them in the methods mentioned above so this PR aims to correct that and in doing so it makes the usage of the Laravel migration system even better / more developer-friendly.The only breaking change is that the
Migrator
now has to take a new parameter in its constructor (the container instance). I also added a test to cover this functionality.