[5.7] Form request improvements #25152
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve two things regarding form requests.
In
ValidatesWhenResolvedTrait
thepasses
method was called on a\Illuminate\Contracts\Validation\Validator
instance even though thepasses
method doesn't exist on the interface. This was adjusted to call thefails
method which is present on the interface and thus I avoided making a breaking change (adding thepasses
method to the interface).Unlike the
rules
andauthorize
methods, themessages
method wasn't called via the container. This was not only inconsistent, but it also meant that I had to write a few more lines than I must now :)Before this PR:
After this PR:
I also added a test that proves that method injecting works with the
messages
method (as well as withrules
andauthorize
methods as that wasn't even tested before).