Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add InteractsWithQueue to SendQueueNotifications #30140

Conversation

@bastien-phi
Copy link
Contributor

commented Sep 30, 2019

This PR adds InteractsWithQueue to SendQueueNotifications.

Indeed, #30070 add ability to send notification through job middleware and classic example RateLimited cannot be used because the job cannot be released to the queue as it does not have InteractsWithQueue.

This could be very useful because some email providers can have rate limitation on sending email.

@taylorotwell taylorotwell merged commit e4a313f into laravel:6.x Sep 30, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bastien-phi bastien-phi deleted the bastien-phi:send-queue-notifications-interacts-with-queue branch Sep 30, 2019
i-bajrai added a commit to i-bajrai/framework that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.