Apply suggestions from code review

Co-authored-by: Joe Dixon <joedixon@users.noreply.github.com>

Author: 2 people

resources/helpers.php

@@ -32,16 +32,14 @@ function route_to_reply_able($replyAble): string
     }
 }
 
-if (! function_exists('linkyfy')) {
+if (! function_exists('replace_links')) {
     /**
      * Convert Standalone Urls to HTML.
      */
-    function linkyfy(string $markdown): string
+    function replace_links(string $markdown): string
     {
-        $lf=new LinkFinder([
-                "attrs" => ["class" => "external-link", "target" => "_blank", "rel" => "nofollow"],
-                "mailto_attrs" => ["class" => "external-email"]
-                ]);
-        return $lf->processHtml($markdown);
+        return (new LinkFinder([
+            "attrs" => ["target" => "_blank", "rel" => "nofollow"],
+        ]))->processHtml($markdown);
     }
 }

resources/views/forum/threads/show.blade.php

@@ -41,7 +41,7 @@ class="text-green-darker mr-2">
                             class="forum-content" 
                             x-data="{}" 
                             x-init="function () { highlightCode($el); }"
-                            x-html="{{ json_encode(linkyfy(md_to_html($thread->body()))) }}"
+                            x-html="{{ json_encode(replace_links(md_to_html($thread->body()))) }}"
                         >
                         </div>
                     </div>
@@ -118,7 +118,7 @@ class="forum-content"
                                     class="forum-content" 
                                     x-data="{}" 
                                     x-init="function () { highlightCode($el); }"
-                                    x-html="{{ json_encode(linkyfy(md_to_html($reply->body()))) }}"
+                                    x-html="{{ json_encode(replace_links(md_to_html($reply->body()))) }}"
                                 >
                                 </div>
                             </div>