Use handle in tweets

Author: joedixon

app/Notifications/PostArticleToTwitter.php

@@ -25,11 +25,17 @@ public function via($notifiable)
     }
 
     public function toTwitter($notifiable)
+    {
+        return new TwitterStatusUpdate($this->generateTweet());
+    }
+
+    public function generateTweet()
     {
         $title = $this->article->title();
         $url = route('articles.show', $this->article->slug());
-        $author = $this->article->author()->name();
+        $author = $this->article->author();
+        $author = $author->twitterHandle() ? "@{$author->twitterHandle()}" : $author->name();
 
-        return new TwitterStatusUpdate("{$title} - {$author}\n\n{$url}");
+        return "{$title} - {$author}\n\n{$url}";
     }
 }

tests/Unit/Commands/PostArticleToTwitterTest.php

@@ -2,13 +2,14 @@
 
 namespace Tests\Unit\Commands;
 
-use Tests\TestCase;
-use App\Models\Article;
-use Illuminate\Support\Facades\Notification;
 use App\Console\Commands\PostArticleToTwitter;
-use Illuminate\Notifications\AnonymousNotifiable;
-use Illuminate\Foundation\Testing\DatabaseMigrations;
+use App\Models\Article;
 use App\Notifications\PostArticleToTwitter as PostArticleToTwitterNotification;
+use Illuminate\Foundation\Testing\DatabaseMigrations;
+use Illuminate\Notifications\AnonymousNotifiable;
+use Illuminate\Support\Facades\Notification;
+use Illuminate\Support\Str;
+use Tests\TestCase;
 
 class PostArticleToTwitterTest extends TestCase
 {
@@ -24,20 +25,74 @@ protected function setUp(): void
     public function published_articles_can_be_shared_on_twitter()
     {
         $article = factory(Article::class)->create([
+            'title' => 'My First Article',
             'submitted_at' => now(),
             'approved_at' => now(),
         ]);
 
         (new PostArticleToTwitter(new AnonymousNotifiable()))->handle();
 
         Notification::assertSentTo(
-            new AnonymousNotifiable,
-            PostArticleToTwitterNotification::class
+            new AnonymousNotifiable(),
+            PostArticleToTwitterNotification::class,
+            function ($notification, $channels, $notifiable) use ($article) {
+                $tweet = $notification->generateTweet();
+                return Str::contains($tweet, 'My First Article') &&
+                Str::contains($tweet, route('articles.show', $article->slug()));
+            }
         );
 
         $this->assertTrue($article->fresh()->isShared());
     }
 
+    /** @test */
+    public function articles_are_shared_with_twitter_handle()
+    {
+        $user = $this->createUser([
+            'twitter_handle' => '_joedixon',
+        ]);
+
+        factory(Article::class)->create([
+            'author_id' => $user->id(),
+            'submitted_at' => now(),
+            'approved_at' => now(),
+        ]);
+
+        (new PostArticleToTwitter(new AnonymousNotifiable()))->handle();
+
+        Notification::assertSentTo(
+            new AnonymousNotifiable(),
+            PostArticleToTwitterNotification::class,
+            function ($notification, $channels, $notifiable) use ($user) {
+                return Str::contains($notification->generateTweet(), '@_joedixon');
+            }
+        );
+    }
+
+    /** @test */
+    public function articles_are_shared_with_name_when_no_twitter_handle()
+    {
+        $user = $this->createUser([
+            'name' => 'Joe Dixon',
+        ]);
+
+        factory(Article::class)->create([
+            'author_id' => $user->id(),
+            'submitted_at' => now(),
+            'approved_at' => now(),
+        ]);
+
+        (new PostArticleToTwitter(new AnonymousNotifiable()))->handle();
+
+        Notification::assertSentTo(
+            new AnonymousNotifiable(),
+            PostArticleToTwitterNotification::class,
+            function ($notification, $channels, $notifiable) use ($user) {
+                return Str::contains($notification->generateTweet(), 'Joe Dixon');
+            }
+        );
+    }
+
     /** @test */
     public function already_shared_articles_are_not_shared_again()
     {