Don't send notifications to repliers

Author: driesvints

app/Listeners/SendNewReplyNotification.php

@@ -4,13 +4,21 @@
 
 use App\Events\ReplyWasCreated;
 use App\Notifications\NewReply;
+use App\User;
 
 class SendNewReplyNotification
 {
-    public function handle(ReplyWasCreated $event)
+    public function handle(ReplyWasCreated $event): void
     {
         foreach ($event->reply->replyAble()->subscriptions() as $subscription) {
-            $subscription->user()->notify(new NewReply());
+            if ($this->replyAuthorDoesNotMatchSubscriber($event->reply->author(), $subscription)) {
+                $subscription->user()->notify(new NewReply());
+            }
         }
     }
+
+    private function replyAuthorDoesNotMatchSubscriber(User $author, $subscription): bool
+    {
+        return ! $author->matches($subscription->user());
+    }
 }

tests/Feature/SubscriptionTest.php

@@ -56,6 +56,20 @@ public function thread_authors_do_not_receive_a_notification_for_a_thread_they_c
         Notification::assertNotSentTo($author, NewReply::class);
     }
 
+    /** @test */
+    public function reply_authors_do_not_receive_a_notification_for_a_thread_they_are_subscribed_to()
+    {
+        Notification::fake();
+
+        $thread = factory(Thread::class)->create();
+        $author = factory(User::class)->create();
+        factory(Subscription::class)->create(['user_id' => $author->id(), 'subscriptionable_id' => $thread->id()]);
+
+        $this->dispatch(new CreateReply($this->faker->text, $this->faker->ipv4, $author, $thread));
+
+        Notification::assertNotSentTo($author, NewReply::class);
+    }
+
     /** @test */
     public function users_are_automatically_subscribed_to_a_thread_after_replying_to_it()
     {