Fix display crash OOB when items exist on first render of top
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of columns used to be calculated from the number of display-column-widths. On first render, this is nil, because needs-resize is t, and nothing has yet been calculated. This however still worked so long the buffer rendered once before adding new entires. If entries existed on first render, the column count would be 0. Fix by calculating column count off of header-widths, which is always set correctly.
5 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of columns used to be calculated from the number of
display-column-widths. On first render, this is nil, becauseneeds-resizeist, and nothing has yet been calculated. This however still worked so long the buffer rendered once before adding new entires. If entries existed on first render, the column count would be 0.Fix by calculating column count off of
header-widths, which is always set correctly.Fixes #40