Skip to content

Fix display crash OOB when items exist on first render of top #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Fix display crash OOB when items exist on first render of top #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions explain-pause-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,10 +578,9 @@ the width cannot be 0."
(let* ((display-order-ptr (cdr (explain-pause-top--table-entries table)))
(display-entries-prev (explain-pause-top--table-display-entries table))
(display-entries-ptr (cdr display-entries-prev))
(display-column-widths (explain-pause-top--table-column-widths table))
(column-count (length display-column-widths))
(requested-widths (copy-sequence
(explain-pause-top--table-header-widths table)))
(column-count (length requested-widths))
(layout-changed nil)
(current-diffs (make-vector column-count nil)))

Expand Down Expand Up @@ -629,7 +628,7 @@ the width cannot be 0."
;; changed. If so, we'll force `draw` to draw full lines:
;; (TODO could we only paint things "after" the first change?)
(when (or
(cl-mismatch display-column-widths
(cl-mismatch (explain-pause-top--table-column-widths table)
requested-widths
:start1 1
:start2 1
Expand Down