fix: fixed bug where the feature store does not deserialize KV values… #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yusinto
commented
Apr 28, 2023
yusinto
commented
- removed { type: 'json' } from KV calls to return default string values from the KV
- expose deserializePoll and use it to deserialize string KV values
- fixed unit tests
|
This pull request has been linked to Shortcut Story #199318: Fix edge sdks serialization bug. |
yusinto
commented
Apr 28, 2023
yusinto
commented
Apr 28, 2023
yusinto
commented
Apr 28, 2023
kinyoklion
reviewed
Apr 28, 2023
kinyoklion
reviewed
Apr 28, 2023
kinyoklion
approved these changes
Apr 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.