fix: Suggestions for serialization. #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Apr 28, 2023
| const store: LDFeatureStore = { | ||
| get( | ||
| kind: DataKind, | ||
| flagKey: string, |
kinyoklion
commented
Apr 28, 2023
| throw new Error(`Error deserializing ${kindKey}`); | ||
| } | ||
| callback(item[kindKey][flagKey]); | ||
| switch (kind.namespace) { |
There was a problem hiding this comment.
This isn't super elegant, but lets us keep the types the same, and we can make it more elegant in the next update.
kinyoklion
commented
Apr 28, 2023
| return parsed; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Just because this isn't a permanent solution, and isn't a function we want a customer to use.
kinyoklion
commented
Apr 28, 2023
| } | ||
|
|
||
| interface FlagsAndSegments { | ||
| [key: string]: { [name: string]: Flag } | { [name: string]: Segment }; |
There was a problem hiding this comment.
FlagsAndSegments isn't intended to be addressed by strings. In places where it isn't flags or segments it would generally be an error. So, this is the main thing I was concerned about.
There was a problem hiding this comment.
Maybe long term DataKind needs to be flags | segments instead of string. But this is out of scope and out of time for my ambitions now.
export interface DataKind {
namespace: 'flags' | 'segments';
}
yusinto
approved these changes
Apr 28, 2023
yusinto
added a commit
that referenced
this pull request
Apr 28, 2023
#107) * fix: fixed bug where the feature store does not deserialize KV values correctly. * chore: remove eslint comment * chore:update example to target rules rather than a contrived scenario. * chore: improve logging and nullish check. * chore: add yarn coverage * chore: debugging null debugEventsUntilDate * chore: set debugEventsUntilDate for unit tests. * fix: Suggestions for serialization. (#111) fix: Suggestions. * chore: removed .only * fix: broken unit tests. minor syntax improvements. --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.