fix: Export correct options for compat. #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Went a little bit too far with the common exports. |
|
@launchdarkly/js-sdk-common size report |
kinyoklion
commented
Nov 8, 2024
| import { BasicLogger, BasicLoggerOptions, LDLogger } from '@launchdarkly/js-client-sdk-common'; | ||
|
|
||
| import { BrowserIdentifyOptions as LDIdentifyOptions } from './BrowserIdentifyOptions'; | ||
| import { BrowserOptions as LDOptions } from './options'; |
There was a problem hiding this comment.
This file shouldn't export options as the compat options are a little different.
kinyoklion
commented
Nov 8, 2024
|
|
||
| export * from '../common'; | ||
| export type { LDClient }; | ||
| export type { LDClient, LDOptions }; |
There was a problem hiding this comment.
Exporting the compat options.
|
@launchdarkly/js-client-sdk size report |
kinyoklion
commented
Nov 8, 2024
|
|
||
| export * from './common'; | ||
| export type { LDClient }; | ||
| export type { LDClient, LDOptions }; |
There was a problem hiding this comment.
Exporting standard browser options.
|
@launchdarkly/js-client-sdk-common size report |
louis-launchdarkly
approved these changes
Nov 12, 2024
cwaldren-ld
approved these changes
Nov 12, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk: 0.3.2</summary> ## [0.3.2](js-client-sdk-v0.3.1...js-client-sdk-v0.3.2) (2024-11-13) ### Bug Fixes * Export correct options for compat. ([#678](#678)) ([8d8250c](8d8250c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.