Skip to content

fix: Export correct options for compat. #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Export correct options for compat. #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/sdk/browser/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { BasicLogger, BasicLoggerOptions, LDLogger } from '@launchdarkly/js-client-sdk-common';

import { BrowserIdentifyOptions as LDIdentifyOptions } from './BrowserIdentifyOptions';
import { BrowserOptions as LDOptions } from './options';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't export options as the compat options are a little different.


// The exported LDIdentifyOptions and LDOptions are the browser specific implementations.
// These shadow the common implementations.
export type { LDIdentifyOptions, LDOptions };
export type { LDIdentifyOptions };

export type {
AutoEnvAttributes,
Expand Down
5 changes: 3 additions & 2 deletions packages/sdk/browser/src/compat/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
* Some code changes may still be required, for example {@link LDOptions} removes
* support for some previously available options.
*/
import { LDContext, LDOptions } from '@launchdarkly/js-client-sdk-common';
import { LDContext } from '@launchdarkly/js-client-sdk-common';

import { LDClient } from './LDClientCompat';
import LDClientCompatImpl from './LDClientCompatImpl';
import { LDOptions } from './LDCompatOptions';

export * from '../common';
export type { LDClient };
export type { LDClient, LDOptions };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporting the compat options.


/**
* Creates an instance of the LaunchDarkly client. This version of initialization is for
Expand Down
4 changes: 2 additions & 2 deletions packages/sdk/browser/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
import { AutoEnvAttributes } from '@launchdarkly/js-client-sdk-common';

import { BrowserClient, LDClient } from './BrowserClient';
import { LDOptions } from './common';
import { BrowserOptions as LDOptions } from './options';

export * from './common';
export type { LDClient };
export type { LDClient, LDOptions };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exporting standard browser options.


/**
* Creates an instance of the LaunchDarkly client.
Expand Down