fix: Prevent command injection in FileDataSourceImpl #341
+29
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked Internally: SDK-1675
Note
Replace IO.read with File.read in FileDataSourceImpl and add tests ensuring filenames aren’t executed as shell commands.
IO.read(path)withFile.read(path)inlib/ldclient-rb/impl/integrations/file_data_source.rbfor direct, shell-free file access.spec/integrations/file_data_source_spec.rb.Written by Cursor Bugbot for commit b38011c. This will update automatically on new commits. Configure here.