fix: Fix diagnostic logging for connection results in stream #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonbailey
commented
Dec 5, 2025
| def initialize(inbox, sdk_key, config, diagnostic_accumulator, event_sender) | ||
| @sdk_key = sdk_key | ||
| @config = config | ||
| @diagnostic_accumulator = config.diagnostic_opt_out? ? nil : diagnostic_accumulator |
Contributor
Author
There was a problem hiding this comment.
The client is responsible for determining if we pass the diagnostic accumulator to the rest of the system based on the opt_out value. This makes the check here redundant and unnecessary.
jsonbailey
commented
Dec 5, 2025
keelerm84
approved these changes
Dec 5, 2025
jsonbailey
pushed a commit
that referenced
this pull request
Dec 5, 2025
🤖 I have created a release *beep* *boop* --- ## [8.11.2](8.11.1...8.11.2) (2025-12-05) ### Bug Fixes * Fix diagnostic logging for connection results in stream ([#343](#343)) ([d49eaa8](d49eaa8)) * Prevent command injection in FileDataSourceImpl ([#341](#341)) ([9ca4b98](9ca4b98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps SDK to 8.11.2, updates changelog with two bug fixes, and refreshes provenance instructions. > > - **Version bump**: > - Update `lib/ldclient-rb/version.rb` to `8.11.2`. > - Update `.release-please-manifest.json` to `8.11.2`. > - Update `PROVENANCE.md` `SDK_VERSION` to `8.11.2`. > - **Documentation**: > - Add `8.11.2` entry to `CHANGELOG.md` noting bug fixes: diagnostic logging for stream connection results; prevent command injection in `FileDataSourceImpl`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit bbadc19. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked internally: SDK-1674
Note
StreamProcessor now records diagnostic connection start/result metrics and tests them; EventDispatcher always keeps the provided diagnostic accumulator; CI action pins Bundler v2.
lib/ldclient-rb/stream.rb(StreamProcessor):@diagnostic_accumulatorand logs connection start/result viarecord_stream_initwith timestamp, failure flag, and duration.log_connection_startedon stream start; records success/failure once per attempt.lib/ldclient-rb/events.rb(EventDispatcher): always assigns@diagnostic_accumulator(removes opt-out gating).spec/stream_spec.rb: add specs covering success/failure logging, timestamp/duration validation, single-log per attempt, and nil accumulator behavior..github/actions/setup/action.yml: pin Bundler to2in setup step.Written by Cursor Bugbot for commit 8b2f035. This will update automatically on new commits. Configure here.