-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding data association taking labels into account #12
Comments
Takes are taken into account when using NN, but not when using NNJPDA. I have not yet checked if the way I have achieved this is back compatible, but it shouldn't be too hard to make back compatible. (I'll test it tomorrow to check, and then do a pull request) If I get time I'll try and look into making NNJPDA work with labels as well. |
I suppose NNJPDA isn't exactly easy as there is no strict 1:1 assignment as it's probabilistic. Just make sure it is backward compatible and the change set is as small as possible. |
Yeah, my IDE auto formatted the code. I'll revert the formatting so there aren't so many changes and ensure it is back compatible 😄 |
I've opened a pull request. See #13 |
closed by #13 |
starting point is looking at https://github.com/LCAS/bayestracking/blob/master/include/bayes_tracking/multitracker.h#L254 and creating another data association alg named
LABELLEDNN
.Use the
AssociationMatrix amat
(withM
being the number of observations andN
being the number of trackers) to assign costs. This is already done by the algorithm. All we need to do is set the cost toDBL_MAX
when the labels do not match up. Observationsobservation_t
already have aflag
field that we can use as it's not used anywhere else to "tag" the observations. But then each "filter"filter_t
also needs to keep track of the assign "tag", so that they can be matched. Maybe extend https://github.com/LCAS/bayestracking/blob/master/include/bayes_tracking/multitracker.h#L59 to facilitate this.@pet1330 can you have a look at this?
The text was updated successfully, but these errors were encountered: