Skip to content

Strings methods: startswith() #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

AbdelrahmanKhaledd
Copy link
Collaborator

No description provided.

@AbdelrahmanKhaledd
Copy link
Collaborator Author

@certik @czgdp1807
Ready for review

s = " empty"
assert s.startswith(" ") == True
assert " @" .startswith(" ") == True
assert " emptyAaaaAABBbbbbBB" .startswith(s) == True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try giving something in the middle portion of the string such as AABB in startswith and see if it returns False. Also give something like emptyAaaX as input to startswith.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added them and edit those corner cases in functions, i think it's ready now.

Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @certik Should we merge this?

@czgdp1807
Copy link
Collaborator

Ah! Resolve the conflicts @Abdelrahman-Kh-Fouad.

@AbdelrahmanKhaledd
Copy link
Collaborator Author

@czgdp1807 Done!

@czgdp1807 czgdp1807 merged commit d12b104 into lcompilers:main Aug 31, 2022
@AbdelrahmanKhaledd AbdelrahmanKhaledd deleted the str@startswith branch August 31, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants