Allow importing of global lists with initializer #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add a test as well. |
|
Just add a test that fails in master but works here and this should be good to go. Just add an integration test. |
Thirumalai-Shaktivel
force-pushed
the
global_syms_02
branch
from
720a3c0 to
d9590ad
Compare
Co-authored-by: Ondřej Čertík <ondrej@certik.us>
Thirumalai-Shaktivel
force-pushed
the
global_syms_02
branch
from
d9590ad to
e74ee9f
Compare
Thirumalai-Shaktivel
force-pushed
the
global_syms_02
branch
from
9eda48b to
914e78c
Compare
Thirumalai-Shaktivel
force-pushed
the
global_syms_02
branch
from
914e78c to
e74ee9f
Compare
czgdp1807
approved these changes
Mar 24, 2023
|
Cool, thanks for the review. Now, I will work on the global statements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.