Skip to content

Fix do loop variable type #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2022
Merged

Fix do loop variable type #822

merged 3 commits into from
Jul 26, 2022

Conversation

Smit-create
Copy link
Collaborator

Fixes #770
Closes #771

@Smit-create Smit-create requested a review from czgdp1807 July 26, 2022 13:54
@czgdp1807
Copy link
Collaborator

There are a couple of places (AFAICT) where the ASR::DoLoop is generated programatically (i.e., by calling ASR::make_DoLoop_t). There the kind of increment variable is 32 bit but it should be taken from the kind of iterator variable. Can you just check for those and add a fix if necessary? Like search for make_DoLoop_t and read the code to see if things are correct.

@czgdp1807 czgdp1807 mentioned this pull request Jul 26, 2022
Closed
@czgdp1807 czgdp1807 added asr ASR related changes asr_pass ASR pass related changes labels Jul 26, 2022
namannimmo10
namannimmo10 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@namannimmo10 namannimmo10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you 👍

@czgdp1807 czgdp1807 merged commit b51b4e6 into lcompilers:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgdp1807 czgdp1807 czgdp1807 approved these changes

@namannimmo10 namannimmo10 namannimmo10 approved these changes

Assignees
No one assigned
Labels
asr_pass ASR pass related changes asr ASR related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DoLoops not working for i64 increment variable
3 participants
@Smit-create @czgdp1807 @namannimmo10