Skip to content

[README] Add rebasing example #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

AbdelrahmanKhaledd
Copy link
Collaborator

No description provided.

@AbdelrahmanKhaledd AbdelrahmanKhaledd changed the title Add rebasing example [README] Add rebasing example Jul 31, 2022
@certik
Copy link
Contributor

certik commented Jul 31, 2022

Excellent, thank you!

@certik certik requested review from namannimmo10 and czgdp1807 July 31, 2022 17:45
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t use this approach for cleaning up my git history. I follow the steps in #783 (comment). Squashing using interactive rebase sometimes leads to messing up of git history so I do it only when its outcome is predictable for me.

@namannimmo10
Copy link
Collaborator

Yep. Maybe we can add another line here, mentioning: "create a backup branch before doing this interactive rebase."

@certik
Copy link
Contributor

certik commented Jul 31, 2022

We should put both approaches there, I use both.

@czgdp1807's approach is what I use for a complicated history with lots of merges, since a rebase will give me conflicts, but the git reset master approach is solid.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start, it has all the information. I think the presentation can be more polished, but we can improve upon it with subsequent PRs I think.

@czgdp1807 czgdp1807 merged commit 3e7635b into lcompilers:main Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants