-
Notifications
You must be signed in to change notification settings - Fork 170
Add bit_length() for integers #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bit_length() for integers #875
Conversation
19420c8
to
7de8d29
Compare
@namannimmo10 i've implemented it on llvm. |
Please add test before we review the code. |
Thanks for the PR! We should: |
7a6ed24
to
d2e695e
Compare
I rebased and changed commits messages. |
d2e695e
to
00f3ce1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Looks good though.
e24c946
to
29e5a79
Compare
@namannimmo10 |
ebe92dd
to
091464a
Compare
Please fix the warnings if you are getting any. We'd have to do that later otherwise. |
@certik @czgdp1807 -- PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that looks good. After comments are addressed, it can be merged. Git history should be polished.
091464a
to
3999906
Compare
@namannimmo10 |
If you do |
1f54929
to
e7fa718
Compare
e7fa718
to
a1e3900
Compare
@Abdelrahman-Kh-Fouad -- now we can add the string-related methods. |
Related to #281