Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Conversation

@mkaratarakis
Copy link
Collaborator

@mkaratarakis mkaratarakis commented Oct 7, 2022

A multiplicative action of a monoid M on a semiring R and a monoid homomorphism N →* M induce a multiplicative action of a monoid N on R.

I need this for my study of the decomposition and inertia groups


Open in Gitpod

`K →+* N` induce a multiplicative action of `K` on `B`.
@alreadydone alreadydone changed the title Adding docs#mul_semiring_action.comp_hom feat(algebra/group_ring_action): add mul_semiring_action.comp_hom Oct 7, 2022
@mkaratarakis mkaratarakis added the awaiting-review The author would like community review of the PR label Oct 7, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mkaratarakis mkaratarakis requested a review from a team as a code owner October 10, 2022 15:12
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 11, 2022
@jcommelin
Copy link
Member

Lint and build are failing. Could you please fix those?

@mkaratarakis mkaratarakis added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 11, 2022
@mkaratarakis
Copy link
Collaborator Author

Thank you. I think these are fixed now - Is there anything else I should do?

@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 11, 2022
@mkaratarakis mkaratarakis added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 11, 2022
@fpvandoorn
Copy link
Member

LGTM

Please merge once CI shows a green checkmark

bors d+

@bors
Copy link

bors bot commented Oct 11, 2022

✌️ mkaratarakis can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
mkaratarakis and others added 2 commits October 15, 2022 11:12
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@mkaratarakis
Copy link
Collaborator Author

OK, thank you. Please let me know if there is anything else

@eric-wieser
Copy link
Member

Also, can you update the PR description? It's no longer accurate

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 15, 2022
bors bot pushed a commit that referenced this pull request Oct 15, 2022
…16850)

A multiplicative action of a monoid `M` on a semiring `R` and a monoid homomorphism `N →* M` induce a multiplicative action of a monoid `N` on `R`.

I need this for my study of the decomposition and inertia groups



Co-authored-by: mkaratarakis <40603357+mkaratarakis@users.noreply.github.com>
@bors
Copy link

bors bot commented Oct 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/group_ring_action): add mul_semiring_action.comp_hom [Merged by Bors] - feat(algebra/group_ring_action): add mul_semiring_action.comp_hom Oct 15, 2022
@bors bors bot closed this Oct 15, 2022
@bors bors bot deleted the mul_semiring_action.comp_hom branch October 15, 2022 19:03
@eric-wieser eric-wieser added the hacktoberfest-accepted Without this label hacktoberfest is scared off by bors label Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hacktoberfest-accepted Without this label hacktoberfest is scared off by bors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants