This repository was archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 292
[Merged by Bors] - feat(algebra/group_ring_action): add mul_semiring_action.comp_hom
#16850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`K →+* N` induce a multiplicative action of `K` on `B`.
mul_semiring_action.comp_hom
eric-wieser
reviewed
Oct 10, 2022
eric-wieser
reviewed
Oct 10, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Lint and build are failing. Could you please fix those? |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…community/mathlib into mul_semiring_action.comp_hom some fixes
|
Thank you. I think these are fixed now - Is there anything else I should do? |
fpvandoorn
reviewed
Oct 11, 2022
|
LGTM Please merge once CI shows a green checkmark bors d+ |
|
✌️ mkaratarakis can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Oct 13, 2022
fpvandoorn
reviewed
Oct 13, 2022
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
eric-wieser
reviewed
Oct 13, 2022
eric-wieser
reviewed
Oct 15, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
OK, thank you. Please let me know if there is anything else |
eric-wieser
reviewed
Oct 15, 2022
…community/mathlib into mul_semiring_action.comp_hom added a section
eric-wieser
reviewed
Oct 15, 2022
|
Also, can you update the PR description? It's no longer accurate |
eric-wieser
approved these changes
Oct 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors merge
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2022
…16850) A multiplicative action of a monoid `M` on a semiring `R` and a monoid homomorphism `N →* M` induce a multiplicative action of a monoid `N` on `R`. I need this for my study of the decomposition and inertia groups Co-authored-by: mkaratarakis <40603357+mkaratarakis@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mul_semiring_action.comp_hommul_semiring_action.comp_hom
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
hacktoberfest-accepted
Without this label hacktoberfest is scared off by bors
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A multiplicative action of a monoid
Mon a semiringRand a monoid homomorphismN →* Minduce a multiplicative action of a monoidNonR.I need this for my study of the decomposition and inertia groups