Skip to content

Commit a88ea9c

Browse files
joneugsterJon Eugster
andcommitted
feat: port Algebra.Order.Monoid.WithTop (#902)
mathlib3: 655994e298904d7e5bbd1e18c95defd7b543eb94 - [x] depends on #910 Not too bad. Mostly renaming instances and a few broken proofs. Things to double-check (all marked with `Porting note`): - `lift` is not implemented yet, I replaced it with `induction`. - In `addSemigroup` I didn't get `repeat` or `repeat'` to work. That could be golfed. - In `WithTop.addHom` the anonymous constructor didn't work, but writing it out, it did. Is that expected? - I'm a bit unsure about coersions. I left in most things and removed (commented out) the lemma `coe_coe_add_hom`. Could be worth gleaming over anything that has `coe` in it's name. Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
1 parent af17f03 commit a88ea9c

File tree

2 files changed

+711
-0
lines changed

2 files changed

+711
-0
lines changed

Mathlib.lean

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ import Mathlib.Algebra.Order.Monoid.NatCast
6060
import Mathlib.Algebra.Order.Monoid.OrderDual
6161
import Mathlib.Algebra.Order.Monoid.TypeTags
6262
import Mathlib.Algebra.Order.Monoid.Units
63+
import Mathlib.Algebra.Order.Monoid.WithTop
6364
import Mathlib.Algebra.Order.Monoid.WithZero.Basic
6465
import Mathlib.Algebra.Order.Monoid.WithZero.Defs
6566
import Mathlib.Algebra.Order.Positive.Ring

0 commit comments

Comments
 (0)