Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Subring): don't import ordered ring classes for basic things #14126

Closed
wants to merge 12 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented Jun 25, 2024

Having the ordered ring hierarchy results available here results in extra effort for typeclass searches.


Open in Gitpod

Copy link

github-actions bot commented Jun 25, 2024

PR summary 354cd7883f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Group.Submonoid.Membership 559 528 -31 (-5.55%)
Mathlib.Algebra.Ring.Subring.Basic 602 572 -30 (-4.98%)
Mathlib.Algebra.Module.Submodule.Ker 615 585 -30 (-4.88%)
Mathlib.Algebra.Module.Submodule.Range 616 586 -30 (-4.87%)
Import changes for all files
Files Import difference
3 files Mathlib.GroupTheory.MonoidLocalization Mathlib.Algebra.GroupWithZero.NonZeroDivisors Mathlib.Algebra.Group.Submonoid.Membership
-31
38 files Mathlib.Algebra.Ring.Subring.MulOpposite Mathlib.Algebra.Module.Submodule.Bilinear Mathlib.LinearAlgebra.BilinearMap Mathlib.Algebra.Ring.Action.Invariant Mathlib.GroupTheory.Submonoid.Inverses Mathlib.LinearAlgebra.Span Mathlib.Algebra.Module.Submodule.Basic Mathlib.Algebra.Ring.Subring.Pointwise Mathlib.Data.DFinsupp.Basic Mathlib.Algebra.Ring.Subsemiring.MulOpposite Mathlib.Algebra.Module.Submodule.Map Mathlib.Algebra.Module.Submodule.Range Mathlib.Algebra.Ring.Subring.Basic Mathlib.RingTheory.NonUnitalSubsemiring.Basic Mathlib.Data.DFinsupp.NeLocus Mathlib.Algebra.DirectSum.Basic Mathlib.GroupTheory.Coprod.Basic Mathlib.RingTheory.NonUnitalSubring.Basic Mathlib.Algebra.Lie.Basic Mathlib.LinearAlgebra.Pi Mathlib.Algebra.Module.Submodule.RestrictScalars Mathlib.Data.DFinsupp.Encodable Mathlib.Algebra.Group.Submonoid.Units Mathlib.Algebra.Module.Submodule.IterateMapComap Mathlib.Algebra.Group.Submonoid.Pointwise Mathlib.Algebra.Module.Submodule.Lattice Mathlib.Algebra.Module.Submodule.Equiv Mathlib.Algebra.DirectSum.Ring Mathlib.Algebra.Ring.Subsemiring.Pointwise Mathlib.Algebra.Module.Submodule.EqLocus Mathlib.Deprecated.Subring Mathlib.Data.DFinsupp.Notation Mathlib.Algebra.Group.Subgroup.Pointwise Mathlib.Algebra.Ring.Subsemiring.Basic Mathlib.Deprecated.Subfield Mathlib.LinearAlgebra.TensorProduct.Basic Mathlib.Algebra.Module.Submodule.LinearMap Mathlib.Algebra.Module.Submodule.Ker
-30
Mathlib.Algebra.BigOperators.Finsupp Mathlib.Algebra.BigOperators.Associated -29
Mathlib.Algebra.Module.Submodule.Order -27
Mathlib.Algebra.Ring.Subsemiring.Order -24
Mathlib.GroupTheory.CoprodI -10
4 files Mathlib.Data.DFinsupp.Multiset Mathlib.Data.DFinsupp.WellFounded Mathlib.Data.DFinsupp.Lex Mathlib.Data.DFinsupp.Order
-4

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jun 25, 2024
@mattrobball
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 87e3329.
There were significant changes against commit 7e4afad:

  Benchmark                                 Metric         Change
  ===============================================================
+ ~Mathlib.GroupTheory.MonoidLocalization   instructions   -14.9%

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 2, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 2, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 2, 2024
@mattrobball mattrobball force-pushed the mrb/keep_ordered_rings_out_of_submonoid_mem branch from 2390cdc to cd39ff0 Compare July 8, 2024 10:44
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for continuing to comb mathlib's import yarn. If this is better for typeclass search, even nicer!
maintainer merge

@grunweg grunweg changed the title chore (Subring): don't import ordered ring classes for basic things chore(Subring): don't import ordered ring classes for basic things Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@j-loreaux
Copy link
Collaborator

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 8, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 8, 2024
…14126)

Having the ordered ring hierarchy results available here results in extra effort for typeclass searches.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Subring): don't import ordered ring classes for basic things [Merged by Bors] - chore(Subring): don't import ordered ring classes for basic things Jul 8, 2024
@mathlib-bors mathlib-bors bot closed this Jul 8, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/keep_ordered_rings_out_of_submonoid_mem branch July 8, 2024 18:56
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants