Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: add missing spaces around = or := #14554

Closed
wants to merge 3 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jul 9, 2024

Follow mathlib style slightly better: "Use spaces on both sides of ":", ":=" or infix operators."

Automatically generated. Not exhaustive, as doing that everywhere has false positives with meta code.


Open in Gitpod

Copy link

github-actions bot commented Jul 9, 2024

PR summary f4bbc7e054

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ homologyπ_comp_leftHomologyIso_inv
+ instance {F G : 𝒳 ⥤ᵇ 𝒴} (α : F ⟶ G) [IsIso α] : IsIso (X := F.toFunctor) α.toNatTrans := by
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· < ·)] :
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· ≤ ·)] :
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· < ·)] :
+ instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· ≤ ·)] :
+ stabilizer_card
++-- exact_succ
- homologyπ_comp_leftHomologyIso_inv:
- instance {F G : 𝒳 ⥤ᵇ 𝒴} (α : F ⟶ G) [IsIso α] : IsIso (X:=F.toFunctor) α.toNatTrans := by
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· < ·)]:
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (swap (· * ·)) (· ≤ ·)]:
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· < ·)]:
- instance {α : Type*} [Mul α] [Preorder α] [CovariantClass α α (· * ·) (· ≤ ·)]:
- stabilizer_card:

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

maintainer merge

Copy link

github-actions bot commented Jul 9, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@jcommelin
Copy link
Member

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@grunweg
Copy link
Collaborator Author

grunweg commented Jul 9, 2024

Thanks for the really fast review!

@grunweg
Copy link
Collaborator Author

grunweg commented Jul 9, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
Follow mathlib style slightly better: "Use spaces on both sides of ":", ":=" or infix operators."

Automatically generated. Not exhaustive, as doing that everywhere has false positives with meta code.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: add missing spaces around = or := [Merged by Bors] - chore: add missing spaces around = or := Jul 9, 2024
@mathlib-bors mathlib-bors bot closed this Jul 9, 2024
@mathlib-bors mathlib-bors bot deleted the MR-spaces-lineends branch July 9, 2024 09:58
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants