Skip to content

Conversation

chenson2018
Copy link
Collaborator

This PR adds simple typing derivations for locally nameless terms, with proofs of progress and preservation.

I have also reversed the directory structure of LambdaCalculus to be the representation then the system, e.g. {LocallyNameless,Named}/{Untyped,STLC}. This matches the namespaces we have been using and better groups together related code.

@chenson2018 chenson2018 requested review from a team as code owners July 23, 2025 21:50
@chenson2018 chenson2018 requested a review from fmontesi July 24, 2025 03:57
@chenson2018
Copy link
Collaborator Author

After this is merged, while we don't have any other PRs pending, I'm going to address all the outstanding lints so we can start with a clean slate.

Could you take a look at the YAML for the lints workflow? I think there is an issue as I'm getting emails that say .github/workflows/lean_lint_suggest.yml: no jobs were run and it's not appearing here on the PR.

@chenson2018
Copy link
Collaborator Author

Thanks for fixing the lint YAML file, seems to be running now. Looking at the output however, it is not catching the lint errors I see locally. I see these messages on the latest run:

warning: nolints file could not be read; treating as empty: scripts/nolints-style.txt
error: `print-style-error.sh` exited with code 255
could not execute external process './scripts/print-style-errors.sh'

@fmontesi
Copy link
Collaborator

fmontesi commented Aug 4, 2025

Thanks for fixing the lint YAML file, seems to be running now. Looking at the output however, it is not catching the lint errors I see locally. I see these messages on the latest run:

warning: nolints file could not be read; treating as empty: scripts/nolints-style.txt
error: `print-style-error.sh` exited with code 255
could not execute external process './scripts/print-style-errors.sh'

Maybe it's got something to do with the version? I'm now using the same they use in mathlib. Otherwise, it might be that we should provide that script?..

@fmontesi fmontesi merged commit bc6e922 into leanprover:main Aug 5, 2025
2 checks passed
@chenson2018 chenson2018 deleted the locally-nameless-stlc-namespace branch August 6, 2025 07:26
fmontesi pushed a commit that referenced this pull request Sep 20, 2025
* first pass at STLC, should consider splitting this file

* structure

* progress

* minimize imports

* docs typo

* docs

* docs

* remove redundant lemma

* style

* style

* eliminate private lemma

* eliminate private lemma

* scope safety theorems

* STLC namespace

* restructure for clarity

* reverse directory structure

* paramaterize Ty base a base type

* rm unused notation

* naming convention

* nicer speelling of Ctx.dom

* rm terminal refine

* style

* use Data.List.Sigma

* use HasWellFormed notation

* Ctx -> Context

* no space before ✓

* link/reference formatting

* indent inductives

* Context name convention

* naming conventions

* style

* naming conventions

* style
thomaskwaring pushed a commit to thomaskwaring/cslib_SKI that referenced this pull request Oct 6, 2025
* first pass at STLC, should consider splitting this file

* structure

* progress

* minimize imports

* docs typo

* docs

* docs

* remove redundant lemma

* style

* style

* eliminate private lemma

* eliminate private lemma

* scope safety theorems

* STLC namespace

* restructure for clarity

* reverse directory structure

* paramaterize Ty base a base type

* rm unused notation

* naming convention

* nicer speelling of Ctx.dom

* rm terminal refine

* style

* use Data.List.Sigma

* use HasWellFormed notation

* Ctx -> Context

* no space before ✓

* link/reference formatting

* indent inductives

* Context name convention

* naming conventions

* style

* naming conventions

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants