Activate mathlib linters and fix some warnings. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cs-lean/reviewers There seems to be agreement about activating all linters but I thought it'd be good to give you a heads-up through a PR. |
|
Can we add this as a workflow too? I think this action is what does it for Mathlib. |
|
Et voila (I hope). :-) |
|
Nice. I guess it will run for the next PR opened? I see some lints in the lambda calculus directory, I can address those. (I'll wait until #17 is done to minimize merge conflicts) |
thomaskwaring
pushed a commit
to thomaskwaring/cslib_SKI
that referenced
this pull request
Oct 6, 2025
* Activate mathlib linters and fix some warnings. * Add lint & suggest action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates the linters from mathlib.