Prevent inlining into module instances #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardt
force-pushed
the
blacklist-module-instance
branch
from
92370c2
to
8ed0645
Compare
We can inline these into module instance statements, but we can't have something like `(7)[0]` so we prevent inlining of numeric literals into index/slice nodes.
rsetaluri
approved these changes
Aug 31, 2020
Prevents numeric literals from being inlined into index/slice nodes
Fix handling of multiple assignments in inlining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix rdaly525/coreir#953
Depends on fix-inline-slice-logic, so pulled into that branch.