Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 Work In Progress Pull Request #1902

Merged
merged 191 commits into from
Oct 19, 2014
Merged

2.0.0 Work In Progress Pull Request #1902

merged 191 commits into from
Oct 19, 2014

Conversation

lukeapage
Copy link
Member

For reference and comparison, help and suggestions welcome

2.0 required 'stuff'

  • Remove dist files and move to a single less.js
  • refactor out environment
  • Get browser building using browserify
  • Tidy up structure. we shouldn't have everything in tree!
  • Move browser.js and lessc_helper.js to the relevant environment folder
  • Tidy up parser - move out input reader and imports etc.
  • make less.render available in all environments and encourage its usage instead of manual creation of parser and toCSS (allowing us to make calling toCSS asyncronous and more complex)
  • move toCSS from parser
  • Move out chunker
  • Move clean-css to lessc dependencies, not an option passed to the parser (or alternately a plugin, along the lines we will also use for autoprefixer)
  • Use promises instead of EventEmitter for less.render
  • deprecate chunker
  • Improved comment parsing
  • move clean css to plugin
  • look at the Error pull request and whether we should inherit in LessError
  • expose everything on less, not just some things. Probably also make it match directories
  • look at how easy it will be to extend import manager - are there any needed api changes?
  • sourcemap support for autoprefixer
  • change import manager to a class?
  • rename env to be context to avoid collisions with our new environment?
  • review current plugins api and compare to issue, see if anything extra is a breaking change.
  • create a logger system with a null logger - tidy up browser logger and test logger
  • Tidy up the environment api if needed and ensure documented in api.js
  • clear file managers added during instance operations -
  • and add a addFileManager to plugin manager
  • Seperate PluginManager and NodePluginManager
  • Make PluginManager be created per instance and run on options
  • Code comments and extraction to form api documentation
  • integrate https://github.com/less/less.js/pull/1972/files
  • Support asyncronous functions (eval will already have the capability to be async. Create a asyncEvalNode which proxies eval/toCSS. Add baseline function then with immediate invocation to the node base class. go through every eval call and after every eval, execute in a then. store promises on env and then complete when finished :S)
  • look at sourcemap defaults and whether any improvements should be made
  • expose file cache
  • if lessc is installed globally can it pick up local plugins?
  • assign a beta version and make sure it doesn't reject the minVersions of plugins because its labelled beta
  • good manual testing or automated testing of lessc

Chris Gross and others added 30 commits November 26, 2013 15:01
…er. Also added automatic updating of ver from package.json to bower.json.
Conflicts:
	package.json
Conflicts:
	lib/less/browser.js
Conflicts:
	lib/less/browser.js
	lib/less/parser.js
…pendent on their parent (currently breaks browser build)
Conflicts:
	lib/less/import-visitor.js
	lib/less/index.js
lukeapage added a commit that referenced this pull request Oct 19, 2014
@lukeapage lukeapage merged commit 9d3ef59 into master Oct 19, 2014
@lukeapage lukeapage deleted the 2_0_0 branch October 19, 2014 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants