Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive mixin calls regression fix. #1929

Merged
merged 1 commit into from
Apr 11, 2014
Merged

Recursive mixin calls regression fix. #1929

merged 1 commit into from
Apr 11, 2014

Conversation

seven-phases-max
Copy link
Member

Fixes detection of recursive calls broken in 6d3414d. Fixes #1915 and #1928 (?).

@lukeapage Let me know if it's better to PR this to the 2.0 branch instead (I'm not sure what state it is in for the moment).

@Xowap
Copy link

Xowap commented Mar 19, 2014

Excellent news, I can confirm that #1928 is fixed by this PR, both in the test file set and in the real-world code.

@lukeapage
Copy link
Member

This will merge fine with my 2.0 pull so I'll just merge it into master

lukeapage added a commit that referenced this pull request Apr 11, 2014
…ion-fix

Recursive mixin calls regression fix.
@lukeapage lukeapage merged commit 5c0b5cf into less:master Apr 11, 2014
@seven-phases-max seven-phases-max deleted the recursive-loop-regression-fix branch April 11, 2014 08:23
@SimonHarte
Copy link

Can you publish this version on npm as well? Currently still getting the error with latest less version from npm.

@punknroll
Copy link

+1 on this. Please put the latest version to npm.

@lukeapage
Copy link
Member

Sorry ive been slow publishing 1.7.1, been busy. Will aim to do it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class redefinition use the mixin in the same name make lessc crash
5 participants