Fixes #3235 #3237
Merged
Fixes #3235 #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinjuarez
approved these changes
Jun 30, 2018
| @@ -1,4 +1,9 @@ | |||
| @val: 10px; | |||
| .no-math { | |||
| @c: 10px + 20px; | |||
There was a problem hiding this comment.
Is this with --strict-math=on?
There was a problem hiding this comment.
N/m just tested and seeing it work as intended.
|
@calvinjuarez Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3235 - Vars storing calculations don't crunch the calculation if the var is used in calc.
The solution here is a bit of a hack, but it shouldn't affect performance. Basically, if we're "inside" a
calc()(in the evaluation stage), it wraps any vars during evaluation as a function call. This switches the math back on in theCallNode, and evaluates all the arguments to the call node before merging the value intocalc().