Properly exit calc mode after use #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #3393, it was found that Less does not properly exit out of calc mode after using it. This causes subsequent variables to be incorrectly evaluated, which results in errors. The code checks if the calculation stack is empty by checking
!this.calcStack, but this does not evaluate to false. This was changed to checking ifthis.calcStack.lengthis 0, which does evaluate to false.Note: The changes introduced by this PR also caused changes in the sourcemap test output, which is why I modified that as well. I'm not sure if this is right or wrong.