-
-
Notifications
You must be signed in to change notification settings - Fork 607
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Also restructure table init to DRY it.
- Loading branch information
Showing
1 changed file
with
51 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit 4d592ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider an integer; nag is good for such a critical thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We're hoping the email notifications will not be critical because most people will be using automated renewal, but if wishes were fishes...
I filed a bug for this: #110. I'm going to leave it out of the change I'm working on right now to avoid letting it spiral out of control.
Depending on how the OCSP signer / expiration mailer ends up working (independent / integrated) this table should perhaps also contain a
BOOL
or such that indicates if expiration emails for the certificate have been sent already.