Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sa: investigate removing requestedNames table #7432

Closed
jsha opened this issue Apr 16, 2024 · 1 comment
Closed

sa: investigate removing requestedNames table #7432

jsha opened this issue Apr 16, 2024 · 1 comment
Assignees
@jsha
Milestone
Sprint 2024-04-16

Comments

@jsha
Copy link
Contributor

jsha commented Apr 16, 2024

requestedNames is our 3rd biggest table by row count and by byte size, and I suspect we don't need it. It's used in GetOrder to calculate order.Names but we could calculate the same thing using the fetched authzs. Investigate the history here and see if we can get rid of it.
@jsha jsha self-assigned this Apr 16, 2024
@aarongable aarongable added this to the Sprint 2024-04-16 milestone Apr 16, 2024
@jsha jsha mentioned this issue Apr 16, 2024
Merged
@jsha
Copy link
Contributor Author

jsha commented Apr 16, 2024

The table was added in #3169. There wasn't significant discussion about whether it would be better to get the relevant info from the authorizations table. Reading that PR and the code I'm convinced that we can remove the requestedNames table easily. I've filed #7435 as step 1. Once that's deployed, we won't be querying the table anymore and we can file a followup PR that removes writes to the table and drops it from the DB.

aarongable pushed a commit that referenced this issue Apr 18, 2024
@jsha
sa: get order names from authorizations (#7435)
89b07f4 
This removes the only place we query the requestedNames table, which
allows us to get rid of it in a subsequent PR (once this one is merged
and deployed).

Part of #7432
@jsha jsha mentioned this issue May 3, 2024
Merged
jsha added a commit that referenced this issue May 6, 2024
@jsha
sa: eliminate requestedNames table (#7471)
e75a821 
Part of #7432

Follows up on #7435, now that
that PR is deployed.
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this issue May 30, 2024
@jsha
sa: get order names from authorizations (letsencrypt#7435)
ee2951f 
This removes the only place we query the requestedNames table, which
allows us to get rid of it in a subsequent PR (once this one is merged
and deployed).

Part of letsencrypt#7432
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this issue May 30, 2024
@jsha
sa: eliminate requestedNames table (letsencrypt#7471)
ed698c6 
Part of letsencrypt#7432

Follows up on letsencrypt#7435, now that
that PR is deployed.
AlinaADmi pushed a commit to plesk/boulder that referenced this issue Jul 29, 2024
@jsha
sa: get order names from authorizations (letsencrypt#7435)
393417e 
This removes the only place we query the requestedNames table, which
allows us to get rid of it in a subsequent PR (once this one is merged
and deployed).

Part of letsencrypt#7432
AlinaADmi pushed a commit to plesk/boulder that referenced this issue Jul 29, 2024
@jsha
sa: eliminate requestedNames table (letsencrypt#7471)
235b8d1 
Part of letsencrypt#7432

Follows up on letsencrypt#7435, now that
that PR is deployed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsha jsha

Labels
None yet
Projects
None yet
Milestone
Sprint 2024-04-16
Development

No branches or pull requests
2 participants
@jsha @aarongable