Refactor into individual executables #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hooo boy, time to rework the Docker infrastructure.... Opened Issue #50. |
| ) | ||
|
|
||
| func main() { | ||
| app := cmd.NewAppShell("boulder-sa") |
There was a problem hiding this comment.
typo? should be boulder-wfe?
jcjones
pushed a commit
that referenced
this pull request
Mar 23, 2015
This was referenced Mar 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls apart the boulder-start executable into a collection of individual executables. This entails a little bit of repetition (which is minimized through the new /cmd/ module), but has the benefit that each executable only has the business logic for its component and RPC logic for its dependencies. So for example, the VA executable has the code to do validation, but none of the RA or CA logic.
This also changes the configuration for the executables, so that they all rely on a single configuration file format. Each executable draws what it needs from the file, so the same file can be used to configure all authorities in a boulder instance, or different config files can be provided to different executables to segment information.