Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go install for dep binaries when building docker #5858

Merged
merged 4 commits into from
Dec 17, 2021

Conversation

beautifulentropy
Copy link
Member

Update the way our docker build script installs the binaries we rely on
at runtime to avoid "go get" deprecation warnings.

Fixes #5744

@beautifulentropy beautifulentropy marked this pull request as ready for review December 16, 2021 03:12
@beautifulentropy beautifulentropy requested a review from a team as a code owner December 16, 2021 03:12
@beautifulentropy
Copy link
Member Author

Oof, I can repro these failures locally. Pushing back to draft.

@beautifulentropy beautifulentropy marked this pull request as draft December 16, 2021 03:19
@aarongable
Copy link
Contributor

My working hypothesis is that pebble-challtestsrv@latest is somehow not the same as what we were getting before, maybe thanks to pebble "not properly supporting modules". But I didn't have the ability to dig into that very well, obvs :)

@beautifulentropy beautifulentropy marked this pull request as ready for review December 16, 2021 22:20
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@beautifulentropy beautifulentropy merged commit 8a1b51f into main Dec 17, 2021
@beautifulentropy beautifulentropy deleted the buildsh-use-install branch December 17, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boulder-tools/build.sh: switch from go get to go install
2 participants