Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boulder-tools/build.sh: switch from go get to go install #5744

Closed
aarongable opened this issue Oct 22, 2021 · 0 comments · Fixed by #5858
Closed

boulder-tools/build.sh: switch from go get to go install #5744

aarongable opened this issue Oct 22, 2021 · 0 comments · Fixed by #5858
Assignees
@beautifulentropy

Comments

@aarongable
Copy link
Contributor

Running tag_and_upload prints the following warning in the middle of its output:

go get: installing executables with 'go get' in module mode is deprecated.                            
        Use 'go install pkg@version' instead.                                                         
        For more information, see https://golang.org/doc/go-get-install-deprecation or run 'go help get' or 'go help install'.

We should follow its advice
This was referenced Dec 9, 2021
Merged
Closed
@beautifulentropy beautifulentropy self-assigned this Dec 16, 2021
@beautifulentropy beautifulentropy mentioned this issue Dec 16, 2021
Merged
beautifulentropy added a commit that referenced this issue Dec 17, 2021
@beautifulentropy
Use go install for dep binaries when building docker (#5858)
8a1b51f 
Update the way our docker build script installs the binaries we rely on
at runtime to avoid "go get" deprecation warnings.

Fixes #5744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beautifulentropy beautifulentropy

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aarongable @beautifulentropy