Deprecate EnforceMultiVA and MultiVAFullResults feature flags #7520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
approved these changes
Jun 3, 2024
Comment on lines
+569
to
+570
| // If we somehow haven't returned early, we need to break the loop once all | ||
| // of the VAs have returned a result. |
There was a problem hiding this comment.
A further available simplification: the return probs.ServerInternal("Too few remote PerformValidation RPC results") line below can be inlined here, in place of the break.
There was a problem hiding this comment.
Yeah, I considered that, but then you still have to have a "this should never happen" return at the bottom of the function anyway, because Go can't tell that it's impossible to actually fall off the loop. So I felt like having one break and one return was cleaner in the end.
pgporada
approved these changes
Jun 4, 2024
pgporada
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags have been true and false, respectively, for years. We do not expect to change them at any time in the future, and their continued existence makes certain parts of the VA code significantly more complex.
Remove all references to them, preserving behavior in the "enforce, but not full results" configuration.
IN-10358 tracks the corresponding config changes