Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify purpose of the testflume CT log #893

Merged
merged 15 commits into from
Feb 6, 2020

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented Feb 4, 2020

Fixes #879

content/en/docs/ct-logs.html Outdated Show resolved Hide resolved
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking the initiative on this!

content/en/docs/ct-logs.html Outdated Show resolved Hide resolved
content/en/docs/ct-logs.html Outdated Show resolved Hide resolved
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Please add full stops (.) at the end of the bulleted list entries since they are full sentences.

Also, under "Test" can you add another bullet: "SCTs from these logs SHOULD NOT be incorporated into publicly trusted certificates."

And I like the division into "Production / Test" but to make the sub-headings clearer let's call them "Production Logs" and "Test Logs"

@pgporada pgporada changed the title Clarify that testflume is strictly for testing Clarify purpose of the testflume CT log Feb 5, 2020
@tdelmas tdelmas self-requested a review February 5, 2020 18:59
@jsha
Copy link
Contributor

jsha commented Feb 5, 2020

@pgporada as long as you're working on this, want to update the description of Oak to say it is Usable now? https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/ct-policy/m4sHsUBq0i0/hLhZ6J18AQAJ

…dangling ul in this file is for accessibility purposes and allows a screenreader to properly group the nested bulleted lists when combined with the partial.
Copy link
Collaborator

@tdelmas tdelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice use of .Inner 😉

i18n/ru.toml Show resolved Hide resolved
layouts/shortcodes/ct_logs.html Show resolved Hide resolved
layouts/shortcodes/ct_logs.html Outdated Show resolved Hide resolved
@tdelmas
Copy link
Collaborator

tdelmas commented Feb 6, 2020

(btw, just in case you don't know it, you can see the preview of the PR with the netlify/letsencrypt/deploy-preview "Details" link : https://deploy-preview-893--letsencrypt.netlify.com/docs/ct-logs/)

@pgporada pgporada requested a review from jsha February 6, 2020 17:12
@tdelmas
Copy link
Collaborator

tdelmas commented Feb 6, 2020

Now, to avoid breaking too much the translations, I think you need to replace in already translated pages the old {{< ct_logs >}} by

{{< ct_logs data="production" >}}
{{< /ct_logs >}}

{{< ct_logs data="testing" >}}
{{< /ct_logs >}}

Without updating the lastmod of those pages, as translators still have to fill the blanks!

Example of a broken translation: https://deploy-preview-893--letsencrypt.netlify.com/de/docs/ct-logs/

@pgporada
Copy link
Member Author

pgporada commented Feb 6, 2020

20twio

@tdelmas
Copy link
Collaborator

tdelmas commented Feb 6, 2020

Perfect, for me it's good to go!

content/en/docs/ct-logs.html Outdated Show resolved Hide resolved
content/en/docs/ct-logs.html Outdated Show resolved Hide resolved
content/en/docs/ct-logs.html Outdated Show resolved Hide resolved
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @pgporada !

@jsha jsha merged commit c6e00f8 into letsencrypt:master Feb 6, 2020
@pgporada pgporada deleted the testflume-ct-log-clarification branch February 6, 2020 19:31
tdelmas pushed a commit to tdelmas/website that referenced this pull request Feb 11, 2020
tdelmas pushed a commit that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CT logs page with description of testflume
3 participants