-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify purpose of the testflume CT log #893
Clarify purpose of the testflume CT log #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for taking the initiative on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Please add full stops (.) at the end of the bulleted list entries since they are full sentences.
Also, under "Test" can you add another bullet: "SCTs from these logs SHOULD NOT be incorporated into publicly trusted certificates."
And I like the division into "Production / Test" but to make the sub-headings clearer let's call them "Production Logs" and "Test Logs"
@pgporada as long as you're working on this, want to update the description of Oak to say it is Usable now? https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/ct-policy/m4sHsUBq0i0/hLhZ6J18AQAJ |
…dangling ul in this file is for accessibility purposes and allows a screenreader to properly group the nested bulleted lists when combined with the partial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice use of .Inner 😉
(btw, just in case you don't know it, you can see the preview of the PR with the netlify/letsencrypt/deploy-preview "Details" link : https://deploy-preview-893--letsencrypt.netlify.com/docs/ct-logs/) |
Now, to avoid breaking too much the translations, I think you need to replace in already translated pages the old {{< ct_logs data="production" >}}
{{< /ct_logs >}}
{{< ct_logs data="testing" >}}
{{< /ct_logs >}} Without updating the Example of a broken translation: https://deploy-preview-893--letsencrypt.netlify.com/de/docs/ct-logs/ |
Perfect, for me it's good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @pgporada !
Fixes #879